Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/config installer #13
Feat/config installer #13
Changes from 36 commits
05d4451
0f38940
7d2303f
9e37251
7a87205
aeaca20
5246822
0dbe64c
90a5dd8
6bd0063
6528b65
2b47572
6c4442a
0a74c0f
7d3a95a
35dbe02
42dc8cb
e357d5f
b7d7b7a
c4fbb9e
02b048e
62c9c31
709ab4a
48d5076
905e2ea
0817865
87afab8
27b6a42
9e458a3
4c86cdf
40edcb7
cc892e9
c074edb
3b7a5ed
c23b12b
84a1554
5a5e53b
aba5a19
406cac7
6688f35
8ff9501
5ce4b43
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't the error test be more relevant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was failing for some reason so I just removed it as it was a no-op either way. Minimal tests will be added in #19