Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/repo select #23

Merged
merged 4 commits into from
Dec 5, 2024
Merged

Feat/repo select #23

merged 4 commits into from
Dec 5, 2024

Conversation

Keyrxng
Copy link
Contributor

@Keyrxng Keyrxng commented Nov 15, 2024

Resolves #20
Requires #13

QA:

repo-select.mp4

@Keyrxng
Copy link
Contributor Author

Keyrxng commented Nov 17, 2024

@zugdev ready for review bud

Copy link

@Keyrxng, this task has been idle for a while. Please provide an update.

@Keyrxng
Copy link
Contributor Author

Keyrxng commented Nov 22, 2024

This is ready but let's wait for #25 first

@Keyrxng Keyrxng marked this pull request as draft November 22, 2024 15:08
@zugdev
Copy link

zugdev commented Nov 22, 2024

Is this a subset of commits in #25?

@Keyrxng
Copy link
Contributor Author

Keyrxng commented Nov 22, 2024

@zugdev technically, this was branched off from #13 but I haven't pulled main in yet and it'll be cleaner pulling #25 into here than the opposite I think

Copy link

@Keyrxng, this task has been idle for a while. Please provide an update.

Keyrxng pushed a commit to ubq-testing/ubiquity-os-plugin-installer that referenced this pull request Nov 26, 2024
use `eslint-plugin-filename-rules`
@Keyrxng
Copy link
Contributor Author

Keyrxng commented Nov 29, 2024

repo-select.mp4

@Keyrxng Keyrxng marked this pull request as ready for review November 29, 2024 02:08
@rndquu rndquu self-requested a review November 29, 2024 15:53
Copy link
Member

@rndquu rndquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partner should be able to add/edit config either for an organization either for an individual repository.

As far as I understand right now a new partner (which doesn't have the .ubiquity-os repository for organization wide config) can not create a config for a whole organization. It should be possible.

@rndquu rndquu marked this pull request as draft November 29, 2024 16:00
@rndquu rndquu mentioned this pull request Nov 29, 2024
@Keyrxng
Copy link
Contributor Author

Keyrxng commented Nov 29, 2024

Partner should be able to add/edit config either for an organization either for an individual repository.

As far as I understand right now a new partner (which doesn't have the .ubiquity-os repository for organization wide config) can not create a config for a whole organization. It should be possible.

Resolved. I did have it pre-merge but I mistakenly removed it during merge and I didn't catch it last night I was tired when I pulled into these PRs and didn't work on them beyond that, apologies.

QA: https://github.com/ubq-testing/bot-ai/blob/main/.github/.ubiquity-os.config.yml

@Keyrxng Keyrxng marked this pull request as ready for review November 30, 2024 01:09
Copy link

@Keyrxng, this task has been idle for a while. Please provide an update.

@rndquu rndquu self-requested a review December 2, 2024 13:33
Copy link
Member

@rndquu rndquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine

@rndquu rndquu requested a review from zugdev December 2, 2024 13:38
@rndquu rndquu merged commit ae1a823 into ubiquity-os:main Dec 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow selecting individual repository
3 participants