Skip to content

Commit

Permalink
fix: move aria-labelledby to outer div
Browse files Browse the repository at this point in the history
  • Loading branch information
pieterlukasse committed Dec 12, 2024
1 parent cbf6704 commit 2e1037d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions js/components/modal.html
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<div
<div aria-labelledby="atlas-modal-dialog-title"
data-bind="modal: $component.showModal, css: classes({ extra: ['modal', fade() ? 'fade' : ''], modifiers: $component.modifiers })"
tabindex="-1" role="dialog">
<div class="modal-dialog"
data-bind="css: classes({ element: 'modal-dialog', extra: [ 'modal-dialog', ...dialogExtraClasses ] })">
<div data-bind="css: 'modal-content'" aria-labelledby="atlas-modal-dialog-title">
<div data-bind="css: 'modal-content'">
<div class="modal-header">
<!-- ko if: backdropClosable -->
<button type="button" class="close" data-dismiss="modal" aria-label="Close"><span
Expand Down

0 comments on commit 2e1037d

Please sign in to comment.