Improve naming of Serial-TL PhyParams #2165
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the naming of the Serial-TL parameterization objects to make it clearer what is generated.
The Decoupled{Internal/External}SyncPhy implementation was determined to be deadlocking, although the condition under which deadlock could occur is effectively impossible on real silicon ... deadlock is only possible if both sides fully saturate the channel and run at the same frequency.
This PR adds a loud warning in the generator when building with that form of flow control.... it should still be safe for test chips, as the chip-FPGA link is always throttled by the FPGA, or by the UART-TSI onto the FPGA.
Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
main
as the base branch?changelog:<topic>
label?changelog:
label?.conda-lock.yml
file if you updated the conda requirements file?Please Backport
?CI Help:
Add the following labels to modify the CI for a set of features.
Generally, a label added only affect subsequent changes to the PR (i.e. new commits, force pushing, closing/reopening).
See
ci:*
for full list of labels:ci:fpga-deploy
- Run FPGA-based E2E testingci:local-fpga-buildbitstream-deploy
- Build local FPGA bitstreams for platforms that are releasedci:disable
- Disable CI