Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with WW3 develop branch 20241220 #2546

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

JessicaMeixner-NOAA
Copy link
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA commented Dec 20, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

This is a draft PR as I continue to do testing. Wanted to share now as this PR is long overdue.

This PR brings in many features of WW3, two answer changing things of note:
The commit from 1/16/2024 changes answers to baselines in UFS and after great efforts to determine the cause we have not been able to. They do not change the answers in meaningful ways -- more to follow.
Another PR in WW3 that changes answers addresses a bug where we don't find points in the unstructured grid if the longitude is +/- 360 from the grid definition.

Commit Message:

Sync WW3 develop (20241220) to dev/ufs-weather-model

Priority:

  • Normal: Has bug fixes and features that are needed for GFS

Git Tracking

UFSWM:

  • None

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Updates/Changes Baselines.

Input data Changes:

  • WW3_Input data will need to be updated.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@DeniseWorthen
Copy link
Collaborator

DeniseWorthen commented Jan 2, 2025

@JessicaMeixner-NOAA From 01/16/2024 there have been by my count 30 PRs to WW3/develop. Some of those are minor, yes, but I think it is poor CM practice to layer on multiple PRs w/o knowing whether they in fact also, unexpectedly, change baselines. We have seen, after all, that standalone testing of WW3 does not cover all the potential impacts w/ UFS (for example I don't believe standalone testing includes debug or restart tests, please correct me if I am mistaken).

At a minimum, I think an independent baseline should be created using the 01/16 commit for all tests using WW3. If you can then independently confirm that your PR branch reproduces that baseline, then I think that is sufficient. But otherwise, the known baseline-changing commit up to/including 01/16/2024 should made as a standalone PR to update dev/ufs-weather-model.

@JessicaMeixner-NOAA
Copy link
Collaborator Author

@DeniseWorthen - I'll start working on multiple PRs.

@JessicaMeixner-NOAA
Copy link
Collaborator Author

The plan for this PR will be to break this up into multiple pieces to show what changes answers/what does not:

First PR will be up to WW3 develop branch commit on Jan 11 (NOAA-EMC/WW3@63f8270) which will not change answers.

Second PR will be WW3 develop branch commit from Jan 16 (NOAA-EMC/WW3@3952826) which should not change answers, but does and we cannot identify the cause after extensive effort.

Third PR will be WW3 develop branch commit from Dec 12 (NOAA-EMC/WW3@d82913b) which does not change answers, however the binary restart files do change by adding an extra variable in commit (NOAA-EMC/WW3@c13d0b1 from May 9th)

Fourth PR will be WW3 top of develop branch at this point, which will change answers in unstructured grid point output because of a bug fix. It will also include the next commit which has an option to save off this output.

This should hopefully address concerns about answers changing and having smaller commits for those. I'll open PRs as soon as I have regression test results ready for posting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants