Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22873 Update CI to clang18 and enable -Werror #3134

Merged
merged 1 commit into from
Sep 19, 2024
Merged

ICU-22873 Update CI to clang18 and enable -Werror #3134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 11 additions & 13 deletions .github/workflows/icu4c.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,8 +314,8 @@ jobs:
run: |
cd icu4c/source && ./runConfigureICU --enable-debug --disable-release Linux/clang && make -j -l4.5 check

# Clang Linux 16 with CPP20 and treat warnings as errors
clang16-cpp20-warning-as-errors:
# Clang Linux 18 with CPP20 and treat warnings as errors
clang18-cpp20-warning-as-errors:
runs-on: ubuntu-latest
strategy:
fail-fast: false
Expand All @@ -325,21 +325,19 @@ jobs:
- '-std=c++20 -stdlib=libc++'
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- name: Install Clang-16
- name: Install Clang-18
run: |
curl -Ls https://apt.llvm.org/llvm-snapshot.gpg.key | sudo apt-key add -
sudo apt-add-repository 'deb http://apt.llvm.org/focal/ llvm-toolchain-focal-16 main'
sudo apt update
sudo apt install -qy clang-16 lld-16 libc++-16-dev libc++abi-16-dev
- name: Clang-16 build and Test
wget https://apt.llvm.org/llvm.sh
rp9-next marked this conversation as resolved.
Show resolved Hide resolved
chmod u+x llvm.sh
sudo ./llvm.sh 18 all
- name: Clang-18 build and Test
env:
CC: clang-16
CXX: clang++-16
# TODO: add '-Werror' after fixing ICU-22873
CPPFLAGS: '-Wall -Wextra -Wctad-maybe-unsupported'
CC: clang-18
CXX: clang++-18
CPPFLAGS: '-Wall -Wextra -Wctad-maybe-unsupported -Werror'
CXXFLAGS: ${{ matrix.flags }}
run: |
cd icu4c/source && ./runConfigureICU --enable-debug --disable-release Linux/clang && make -j -l4.5 check
cd icu4c/source && ./runConfigureICU --enable-debug --disable-release Linux && make -j -l4.5 check

# MacOS with clang
macos-clang:
Expand Down