Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(family): remove family provider from dependsOn #25

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented Jan 4, 2024

Description of your changes

remove family provider from dependsOn

when providers installed before family provider we can see that configurations Healthy Unknown:

configurationrevision.pkg.crossplane.io/upbound-configuration-aws-network-6c745f1836c1      Unknown   1          xpkg.upbound.io/upbound/configuration-aws-network:v0.6.0      Active   3           3               4m15s

with the following error:

   Message:               cannot resolve package dependencies: incompatible dependencies: [xpkg.upbound.io/upbound/provider-family-aws]
providerrevision.pkg.crossplane.io/upbound-provider-aws-rds-58f96aa9fc4b                 True      1          xpkg.upbound.io/upbound/provider-aws-rds:v0.47.0                 Active   1           1               4m25s
providerrevision.pkg.crossplane.io/upbound-provider-family-aws-fec919bd2218              True      1          xpkg.upbound.io/upbound/provider-family-aws:v0.47.1              Active                               3m18s

Fixes #

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
@haarchri
Copy link
Member Author

haarchri commented Jan 4, 2024

related to: upbound/configuration-aws-database#7

@haarchri
Copy link
Member Author

haarchri commented Jan 4, 2024

/test-examples

Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch!

@haarchri haarchri merged commit 10b0507 into main Jan 4, 2024
2 checks passed
@haarchri haarchri deleted the fix/family-provider branch January 4, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants