Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage SamWithReceiver #596

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Leverage SamWithReceiver #596

merged 1 commit into from
Feb 4, 2024

Conversation

mateuszkwiecinski
Copy link
Member

No description provided.

@mateuszkwiecinski mateuszkwiecinski enabled auto-merge (squash) February 4, 2024 08:00
Copy link

github-actions bot commented Feb 4, 2024

Diffuse output:

OLD: diffuse-base-file
NEW: android.jar

       │         compressed          │         uncompressed          
       ├──────────┬──────────┬───────┼───────────┬───────────┬───────
 JAR   │ old      │ new      │ diff  │ old       │ new       │ diff  
───────┼──────────┼──────────┼───────┼───────────┼───────────┼───────
 class │ 58.2 KiB │ 58.1 KiB │ -24 B │ 124.6 KiB │ 124.6 KiB │ -21 B 
 other │  2.3 KiB │  2.3 KiB │   0 B │     345 B │     345 B │   0 B 
───────┼──────────┼──────────┼───────┼───────────┼───────────┼───────
 total │ 60.5 KiB │ 60.5 KiB │ -24 B │   125 KiB │   125 KiB │ -21 B 

 CLASSES │ old │ new │ diff       
─────────┼─────┼─────┼────────────
 classes │  34 │  34 │  0 (+0 -0) 
 methods │ 248 │ 249 │ +1 (+2 -1) 
  fields │  41 │  41 │  0 (+0 -0)
JAR
    compressed    │   uncompressed   │                                                                                                                            
──────────┬───────┼──────────┬───────┤                                                                                                                            
 size     │ diff  │ size     │ diff  │ path                                                                                                                       
──────────┼───────┼──────────┼───────┼────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
  2.2 KiB │ -18 B │  4.8 KiB │ -27 B │ ∆ com/project/starter/modules/internal/AndroidPluginUtilsKt_configureAndroidProject_4.class                                
    3 KiB │ -18 B │  8.6 KiB │ -31 B │ ∆ com/project/starter/modules/plugins/AndroidLibraryPlugin.class                                                           
  2.2 KiB │  +6 B │    5 KiB │  +9 B │ ∆ com/project/starter/modules/internal/AndroidPluginUtilsKt_configureAndroidProject__inlined_withExtension_1.class         
  1.1 KiB │  -5 B │  1.7 KiB │  +3 B │ ∆ com/project/starter/quality/internal/AndroidCoverageKt_configureAndroidCoverage_1.class                                  
  2.1 KiB │  +4 B │    5 KiB │  +9 B │ ∆ com/project/starter/modules/plugins/AndroidLibraryPlugin_apply_lambda_1__inlined_configureAndroidProject_2.class         
  2.2 KiB │  +4 B │  5.1 KiB │  +9 B │ ∆ com/project/starter/modules/plugins/AndroidApplicationPlugin_apply_lambda_1__inlined_configureAndroidProject_2.class     
  2.2 KiB │  +3 B │    5 KiB │   0 B │ ∆ com/project/starter/quality/internal/AndroidCoverageKt_configureAndroidCoverage_3.class                                  
  1.6 KiB │  +3 B │  3.4 KiB │  +7 B │ ∆ com/project/starter/modules/internal/AndroidPluginUtilsKt_configureAndroidProject_2.class                                
  1.5 KiB │  -3 B │    3 KiB │   0 B │ ∆ com/project/starter/modules/plugins/AndroidLibraryPlugin_apply_lambda_1__inlined_configureAndroidProject_2_1_1.class     
  1.5 KiB │  -3 B │    3 KiB │   0 B │ ∆ com/project/starter/modules/plugins/AndroidApplicationPlugin_apply_lambda_1__inlined_configureAndroidProject_2_1_1.class 
  1.1 KiB │  +2 B │  1.5 KiB │  +6 B │ ∆ com/project/starter/modules/internal/AndroidPluginUtilsKt_dependsOn_1.class                                              
  1.3 KiB │  -1 B │  2.2 KiB │  +1 B │ ∆ com/project/starter/quality/internal/AndroidCoverageKt_configureAndroidCoverage_3_1_1.class                              
  4.6 KiB │  +1 B │ 11.2 KiB │  -6 B │ ∆ com/project/starter/quality/internal/AndroidCoverageKt_configureAndroidCoverage_3_1.class                                
  2.3 KiB │  -1 B │  5.1 KiB │   0 B │ ∆ com/project/starter/quality/internal/AndroidCoverageKt.class                                                             
  1.4 KiB │  +1 B │  2.8 KiB │   0 B │ ∆ com/project/starter/modules/internal/AndroidPluginUtilsKt_configureAndroidProject_3_forbidJavaFiles_1_1.class            
  1.4 KiB │  +1 B │  2.5 KiB │  -1 B │ ∆ com/project/starter/modules/plugins/AndroidApplicationPlugin_apply_lambda_1__inlined_configureAndroidProject_2_2.class   
  1.4 KiB │  -1 B │  2.5 KiB │  -1 B │ ∆ com/project/starter/modules/plugins/AndroidLibraryPlugin_apply_lambda_1__inlined_configureAndroidProject_2_2.class       
    3 KiB │  +1 B │  8.6 KiB │  -5 B │ ∆ com/project/starter/modules/plugins/AndroidApplicationPlugin.class                                                       
  1.4 KiB │   0 B │  2.2 KiB │  +7 B │ ∆ com/project/starter/quality/internal/AndroidCoverageKt_configureAndroidCoverage_2.class                                  
  1.3 KiB │   0 B │  2.5 KiB │  -1 B │ ∆ com/project/starter/modules/internal/AndroidPluginUtilsKt_configureAndroidProject_3_1.class                              
──────────┼───────┼──────────┼───────┼────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
 38.6 KiB │ -24 B │ 85.6 KiB │ -21 B │ (total)
CLASSES
METHODS:

   old │ new │ diff       
  ─────┼─────┼────────────
   248 │ 249 │ +1 (+2 -1) 
  + org.gradle.testing.jacoco.tasks.JacocoReport getLogger() → Logger
  + org.gradle.testing.jacoco.tasks.JacocoReport getProject() → Project
  
  - org.gradle.api.Project getLogger() → Logger

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (19507f6) 0.00% compared to head (de84bc8) 83.09%.

Files Patch % Lines
...ect/starter/modules/internal/AndroidPluginUtils.kt 40.00% 3 Missing ⚠️
...oject/starter/modules/tasks/ForbidJavaFilesTask.kt 0.00% 2 Missing and 1 partial ⚠️
...m/project/starter/quality/plugins/QualityPlugin.kt 62.50% 3 Missing ⚠️
...ect/starter/modules/plugins/KotlinLibraryPlugin.kt 66.66% 0 Missing and 2 partials ⚠️
...n/kotlin/com/project/starter/config/PluginUtils.kt 0.00% 1 Missing ⚠️
...oject/starter/modules/tasks/ProjectCoverageTask.kt 0.00% 1 Missing ⚠️
...m/project/starter/modules/tasks/ProjectLintTask.kt 0.00% 1 Missing ⚠️
...m/project/starter/modules/tasks/ProjectTestTask.kt 0.00% 1 Missing ⚠️
...lin/com/project/starter/quality/internal/Detekt.kt 85.71% 1 Missing ⚠️
...om/project/starter/quality/tasks/IssueLinksTask.kt 75.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master     #596       +/-   ##
=============================================
+ Coverage          0   83.09%   +83.09%     
- Complexity        0       46       +46     
=============================================
  Files             0       28       +28     
  Lines             0      426      +426     
  Branches          0       42       +42     
=============================================
+ Hits              0      354      +354     
- Misses            0       50       +50     
- Partials          0       22       +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mateuszkwiecinski mateuszkwiecinski merged commit 4b4068b into master Feb 4, 2024
28 checks passed
@mateuszkwiecinski mateuszkwiecinski deleted the updates branch February 4, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant