Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: queue message payloads #20749

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: queue message payloads #20749

wants to merge 2 commits into from

Conversation

caalador
Copy link
Contributor

Add sent payloads to message
queue and resend if no response
to message inside MaxMessageSuspendTimeout

fixes #20507

Copy link

github-actions bot commented Dec 19, 2024

Test Results

1 116 files   -  43  1 116 suites   - 43   1h 32m 33s ⏱️ -47s
7 278 tests  - 303  7 215 ✅  - 310  56 💤 ±0  2 ❌ +2  5 🔥 +5 
7 626 runs   - 316  7 553 ✅  - 324  66 💤 +1  2 ❌ +2  5 🔥 +5 

For more details on these failures and errors, see this check.

Results for commit 0846385. ± Comparison against base commit e365417.

This pull request removes 305 and adds 2 tests. Note that renamed tests count towards both.
com.vaadin.client.flow.ClientEngineSizeIT ‑ testClientEngineSize
com.vaadin.flow.spring.DevModeBrowserLauncherHttpsProtoTest ‑ getUrl_withHttpsProto_givesUrlWithHttpsInUrl
com.vaadin.flow.spring.DevModeBrowserLauncherNoPropertiesTest ‑ getUrl_noProperties_givesUrlWithNoContextPathAndUrlMapping
com.vaadin.flow.spring.DevModeBrowserLauncherServletMappingTest ‑ getUrl_withContextPath_givesUrlWithContextPathAndNoUrlMapping
com.vaadin.flow.spring.DevModeBrowserLauncherVaadinAndServletMappingTest ‑ getUrl_withContextPathAndUrlMapping_givesUrlWithContextPathAndUrlMapping
com.vaadin.flow.spring.DevModeBrowserLauncherVaadinMappingTest ‑ getUrl_withUrlMapping_givesUrlWithUrlMappingAndNoContextPath
com.vaadin.flow.spring.DevModeHandlerStopTest ‑ devModeStartupListener_contextDestroyAfterSpringContextClosed_shouldNotThrow
com.vaadin.flow.spring.DevModeHandlerStopTest ‑ shutdownCommandsShouldBeExecutedOnStoppingDevModeHandlerManager
com.vaadin.flow.spring.PrefixTreeTest ‑ hasPrefix_containsPrefix_returnsTrue
com.vaadin.flow.spring.PrefixTreeTest ‑ hasPrefix_doesNotContainPrefix_returnsFalse
…
com.vaadin.flow.misc.ui.TestNoResponseIT ‑ clickWhileRequestPending_clientQueuesRequests_messagesSentCorrectly[any_Chrome_]
com.vaadin.flow.misc.ui.TestNoResponseIT ‑ noResponseForRequest_clientResendsRequest_serverAnswersCorrectly[any_Chrome_]

♻️ This comment has been updated with latest results.

@caalador caalador force-pushed the issues/20507-client-queue branch 7 times, most recently from 5b7dfd6 to 8cf6097 Compare December 23, 2024 08:56
@caalador caalador force-pushed the issues/20507-client-queue branch from 8cf6097 to 8aa6603 Compare January 2, 2025 09:02
Add sent payloads to message
queue and resend if no response
to message inside MaxMessageSuspendTimeout

fixes #20507
Fix queued message send timing.
@caalador caalador force-pushed the issues/20507-client-queue branch from 8aa6603 to 0846385 Compare January 3, 2025 13:15
Copy link

sonarqubecloud bot commented Jan 3, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client to queue request messages to server and resend them when needed
2 participants