-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Select): enforce content update after render #156
Conversation
@vursen, is this expression expected to work? render(<Select renderer={Renderer} value="bar" />);
expect(document.querySelector('vaadin-select-value-button')).to.have.text('Bar');
render(<Select renderer={Renderer} value="foo" />);
expect(document.querySelector('vaadin-select-value-button')).to.have.text('Foo'); |
I believe so, unless React renders this asynchronously. |
Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
==========================================
- Coverage 99.36% 98.22% -1.15%
==========================================
Files 24 25 +1
Lines 158 169 +11
Branches 13 16 +3
==========================================
+ Hits 157 166 +9
- Misses 0 1 +1
- Partials 1 2 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
"./SideNav": "./SideNav.js", | ||
"./SideNavItem": "./SideNavItem.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were these SideNav exports intentionally included in this PR? Looks like an unrelated change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess, it was done by a script, because we already have SideNav
on line 421, but no supporting export on 538. I would suggest to leave it here because we would need to include it anyway (and probably it's gonna be generated on each script run).
Fixes #148.
Also this PR simplifies the testing approach (only for
Select
component) to avoid weird failures.