Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Swift versions required by Vapor #1024

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Update Swift versions required by Vapor #1024

merged 3 commits into from
Dec 9, 2024

Conversation

0xTim
Copy link
Member

@0xTim 0xTim commented Dec 9, 2024

No description provided.

@0xTim 0xTim requested review from a team and gwynne as code owners December 9, 2024 18:53
@0xTim 0xTim added the no-translation-needed This PR does not require the translations to be updated (e.g. fixing a typo or infrastructure work) label Dec 9, 2024
vzsg
vzsg reviewed Dec 9, 2024
View reviewed changes
Copy link
Member

@vzsg vzsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few of the 5.9s turned into 9.

docs/install/linux.ja.md Outdated Show resolved Hide resolved
docs/install/linux.ko.md Outdated Show resolved Hide resolved
docs/install/macos.es.md Outdated Show resolved Hide resolved
docs/install/macos.nl.md Outdated Show resolved Hide resolved
@vzsg
Copy link
Member

vzsg commented Dec 9, 2024 •
edited
Loading

Also, now that Swift versions are on the table, do you think the hard requirement of Xcode 16 can be addressed?

Thanks :)

@0xTim @vzsg
Apply suggestions from code review
f118bd5 
Co-authored-by: Zsolt Váradi <1783465+vzsg@users.noreply.github.com>
@0xTim
Copy link
Member Author

0xTim commented Dec 9, 2024

Yep done in a separate PR to trigger the translations automation

@0xTim 0xTim merged commit 28438d0 into main Dec 9, 2024
1 check passed
@0xTim 0xTim deleted the swift-vapor-update branch December 9, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzsg vzsg vzsg left review comments

@gwynne gwynne gwynne approved these changes

@alemohamad alemohamad alemohamad approved these changes

Assignees
No one assigned
Labels
no-translation-needed This PR does not require the translations to be updated (e.g. fixing a typo or infrastructure work)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xTim @vzsg @alemohamad @gwynne