Implement recoverAndTry and recoverAllAndTry #2948
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your submission! This is looking good! Give me a second to process it - I'm now in the process of scoping changes that could go into the next major version, and we don't often get a shot to make some backward-incompatible API changes |
|
Thanks for the review @pivovarit! Ah I see, alright. Maybe it is a better idea to make a pull request to version/0.x branch first? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing recoverAndTry and recoverAllAndTry as I believe they will provide syntactic ease. I was craving these functions in my daily development work. So here is a pull request. Kindly review.
Edit: I will also make an alike change in the version branch as well if it is fine.