-
-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use JUnit @Nested classes for tests instead of comment sections #2960
base: version/1.x
Are you sure you want to change the base?
Conversation
This reverts commit 89c20aa.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2960 +/- ##
=========================================
Coverage 92.74% 92.74%
- Complexity 5247 5262 +15
=========================================
Files 89 89
Lines 12538 12552 +14
Branches 1604 1598 -6
=========================================
+ Hits 11628 11641 +13
- Misses 721 723 +2
+ Partials 189 188 -1 ☔ View full report in Codecov by Sentry. |
|
||
class ClzMatch {} | ||
class ClzMatch1 extends ClzMatch {} | ||
class ClzMatch2 extends ClzMatch {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed these to non-static since static inner classes are not supported in JDK 8
This reverts commit fcdf049.
note: there's now |
Fix #2951
Generator.sc
so that generated tests use@Nested
classes@Nested
classes in all standalone tests@Nested
classes in inherited tests@Nested
classesTest
and used@DisplayName
Notes: