-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove manifest retries in production builds #74280
Conversation
feedthejim
commented
Dec 24, 2024
•
edited
Loading
edited
- Next.js might retry reading a manifest it needs for rendering the page in dev because the compiler might not have outputted that particular manifest to the disk
- this behaviour is not really needed in production because the manifests has to be outputted beforehand
- however in particular cases, Next.js might try to read a non-existent path, leading to wasteful retries
- this PR just removes that single retry because there's no reason to have it
- this PR does not fix the underlying bug that might cause Next.js to read that path, but we'll be fixing this in a separate PR
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
build cache
Diff detailsDiff for main-HASH.jsDiff too large to display |
Failing test suitesCommit: f928526
Expand output● clientTraceMetadata › app router › should inject propagation data for a dynamically server-side-rendered page
● clientTraceMetadata › app router › hard loading a dynamic page twice should yield different dynamic trace data
● clientTraceMetadata › app router › should only insert the client trace metadata once
● clientTraceMetadata › app router › next dev only › should inject propagation data for a statically server-side-rendered page
● clientTraceMetadata › app router › next dev only › soft navigating to a dynamic page should not transform previous propagation data
● clientTraceMetadata › app router › next dev only › soft navigating to a static page should not transform previous propagation data
● clientTraceMetadata › pages router › should inject propagation data for a dynamically server-side-rendered page
● clientTraceMetadata › pages router › hard loading a dynamic page twice should yield different dynamic trace data
● clientTraceMetadata › pages router › next dev only › should inject propagation data for a statically server-side-rendered page
● clientTraceMetadata › pages router › next dev only › soft navigating to a dynamic page should not transform previous propagation data
● clientTraceMetadata › pages router › next dev only › soft navigating to a static page should not transform previous propagation data
Read more about building and testing Next.js in contributing.md. |