Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove manifest retries in production builds #74280

Closed
wants to merge 1 commit into from

Conversation

feedthejim
Copy link
Contributor

@feedthejim feedthejim commented Dec 24, 2024

  • Next.js might retry reading a manifest it needs for rendering the page in dev because the compiler might not have outputted that particular manifest to the disk
  • this behaviour is not really needed in production because the manifests has to be outputted beforehand
  • however in particular cases, Next.js might try to read a non-existent path, leading to wasteful retries
  • this PR just removes that single retry because there's no reason to have it
  • this PR does not fix the underlying bug that might cause Next.js to read that path, but we'll be fixing this in a separate PR

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Dec 24, 2024
@feedthejim feedthejim marked this pull request as ready for review December 24, 2024 16:15
@feedthejim feedthejim requested a review from ztanner December 24, 2024 16:15
@ijjk
Copy link
Member

ijjk commented Dec 24, 2024

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js feedthejim/fix-retry Change
buildDuration 18.5s 16s N/A
buildDurationCached 15.1s 12.8s N/A
nodeModulesSize 416 MB 416 MB N/A
nextStartRea..uration (ms) 467ms 469ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js feedthejim/fix-retry Change
1187-HASH.js gzip 52.4 kB 52.4 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.36 kB 5.36 kB N/A
bccd1874-HASH.js gzip 52.8 kB 52.8 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js feedthejim/fix-retry Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js feedthejim/fix-retry Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.49 kB 4.49 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js feedthejim/fix-retry Change
_buildManifest.js gzip 749 B 746 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js feedthejim/fix-retry Change
index.html gzip 522 B 524 B N/A
link.html gzip 537 B 538 B N/A
withRouter.html gzip 518 B 520 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js feedthejim/fix-retry Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 206 kB 206 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js feedthejim/fix-retry Change
middleware-b..fest.js gzip 669 B 665 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js feedthejim/fix-retry Change
274-experime...dev.js gzip 322 B 322 B
274.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 359 kB 359 kB
app-page-exp..prod.js gzip 129 kB 129 kB
app-page-tur..prod.js gzip 142 kB 142 kB
app-page-tur..prod.js gzip 137 kB 137 kB
app-page.run...dev.js gzip 347 kB 347 kB
app-page.run..prod.js gzip 125 kB 125 kB
app-route-ex...dev.js gzip 37.5 kB 37.5 kB
app-route-ex..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.5 kB 25.5 kB
app-route-tu..prod.js gzip 25.4 kB 25.4 kB
app-route.ru...dev.js gzip 39.2 kB 39.2 kB
app-route.ru..prod.js gzip 25.4 kB 25.4 kB
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB
pages-turbo...prod.js gzip 21.7 kB 21.7 kB
pages.runtim...dev.js gzip 27.5 kB 27.5 kB
pages.runtim..prod.js gzip 21.7 kB 21.7 kB
server.runti..prod.js gzip 916 kB 916 kB N/A
Overall change 1.52 MB 1.52 MB
build cache
vercel/next.js canary vercel/next.js feedthejim/fix-retry Change
0.pack gzip 2.08 MB 2.08 MB N/A
index.pack gzip 74.7 kB 73.5 kB N/A
Overall change 0 B 0 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: f928526

@ijjk
Copy link
Member

ijjk commented Dec 24, 2024

Failing test suites

Commit: f928526

__NEXT_EXPERIMENTAL_PPR=true pnpm test-dev test/e2e/opentelemetry/client-trace-metadata/client-trace-metadata.test.ts (PPR)

  • clientTraceMetadata > app router > should inject propagation data for a dynamically server-side-rendered page
  • clientTraceMetadata > app router > hard loading a dynamic page twice should yield different dynamic trace data
  • clientTraceMetadata > app router > should only insert the client trace metadata once
  • clientTraceMetadata > app router > next dev only > should inject propagation data for a statically server-side-rendered page
  • clientTraceMetadata > app router > next dev only > soft navigating to a dynamic page should not transform previous propagation data
  • clientTraceMetadata > app router > next dev only > soft navigating to a static page should not transform previous propagation data
  • clientTraceMetadata > pages router > should inject propagation data for a dynamically server-side-rendered page
  • clientTraceMetadata > pages router > hard loading a dynamic page twice should yield different dynamic trace data
  • clientTraceMetadata > pages router > next dev only > should inject propagation data for a statically server-side-rendered page
  • clientTraceMetadata > pages router > next dev only > soft navigating to a dynamic page should not transform previous propagation data
  • clientTraceMetadata > pages router > next dev only > soft navigating to a static page should not transform previous propagation data
Expand output

● clientTraceMetadata › app router › should inject propagation data for a dynamically server-side-rendered page

Failed to start server after 10000ms, waiting for this log pattern: / ✓ Ready in /

  349 |     return setTimeout(() => {
  350 |       reject(
> 351 |         new Error(
      |         ^
  352 |           `Failed to start server after ${ms}ms, waiting for this log pattern: ${this.serverReadyPattern}`
  353 |         )
  354 |       )

  at Timeout._onTimeout (lib/next-modes/base.ts:351:9)

● clientTraceMetadata › app router › hard loading a dynamic page twice should yield different dynamic trace data

Failed to start server after 10000ms, waiting for this log pattern: / ✓ Ready in /

  349 |     return setTimeout(() => {
  350 |       reject(
> 351 |         new Error(
      |         ^
  352 |           `Failed to start server after ${ms}ms, waiting for this log pattern: ${this.serverReadyPattern}`
  353 |         )
  354 |       )

  at Timeout._onTimeout (lib/next-modes/base.ts:351:9)

● clientTraceMetadata › app router › should only insert the client trace metadata once

Failed to start server after 10000ms, waiting for this log pattern: / ✓ Ready in /

  349 |     return setTimeout(() => {
  350 |       reject(
> 351 |         new Error(
      |         ^
  352 |           `Failed to start server after ${ms}ms, waiting for this log pattern: ${this.serverReadyPattern}`
  353 |         )
  354 |       )

  at Timeout._onTimeout (lib/next-modes/base.ts:351:9)

● clientTraceMetadata › app router › next dev only › should inject propagation data for a statically server-side-rendered page

Failed to start server after 10000ms, waiting for this log pattern: / ✓ Ready in /

  349 |     return setTimeout(() => {
  350 |       reject(
> 351 |         new Error(
      |         ^
  352 |           `Failed to start server after ${ms}ms, waiting for this log pattern: ${this.serverReadyPattern}`
  353 |         )
  354 |       )

  at Timeout._onTimeout (lib/next-modes/base.ts:351:9)

● clientTraceMetadata › app router › next dev only › soft navigating to a dynamic page should not transform previous propagation data

Failed to start server after 10000ms, waiting for this log pattern: / ✓ Ready in /

  349 |     return setTimeout(() => {
  350 |       reject(
> 351 |         new Error(
      |         ^
  352 |           `Failed to start server after ${ms}ms, waiting for this log pattern: ${this.serverReadyPattern}`
  353 |         )
  354 |       )

  at Timeout._onTimeout (lib/next-modes/base.ts:351:9)

● clientTraceMetadata › app router › next dev only › soft navigating to a static page should not transform previous propagation data

Failed to start server after 10000ms, waiting for this log pattern: / ✓ Ready in /

  349 |     return setTimeout(() => {
  350 |       reject(
> 351 |         new Error(
      |         ^
  352 |           `Failed to start server after ${ms}ms, waiting for this log pattern: ${this.serverReadyPattern}`
  353 |         )
  354 |       )

  at Timeout._onTimeout (lib/next-modes/base.ts:351:9)

● clientTraceMetadata › pages router › should inject propagation data for a dynamically server-side-rendered page

Failed to start server after 10000ms, waiting for this log pattern: / ✓ Ready in /

  349 |     return setTimeout(() => {
  350 |       reject(
> 351 |         new Error(
      |         ^
  352 |           `Failed to start server after ${ms}ms, waiting for this log pattern: ${this.serverReadyPattern}`
  353 |         )
  354 |       )

  at Timeout._onTimeout (lib/next-modes/base.ts:351:9)

● clientTraceMetadata › pages router › hard loading a dynamic page twice should yield different dynamic trace data

Failed to start server after 10000ms, waiting for this log pattern: / ✓ Ready in /

  349 |     return setTimeout(() => {
  350 |       reject(
> 351 |         new Error(
      |         ^
  352 |           `Failed to start server after ${ms}ms, waiting for this log pattern: ${this.serverReadyPattern}`
  353 |         )
  354 |       )

  at Timeout._onTimeout (lib/next-modes/base.ts:351:9)

● clientTraceMetadata › pages router › next dev only › should inject propagation data for a statically server-side-rendered page

Failed to start server after 10000ms, waiting for this log pattern: / ✓ Ready in /

  349 |     return setTimeout(() => {
  350 |       reject(
> 351 |         new Error(
      |         ^
  352 |           `Failed to start server after ${ms}ms, waiting for this log pattern: ${this.serverReadyPattern}`
  353 |         )
  354 |       )

  at Timeout._onTimeout (lib/next-modes/base.ts:351:9)

● clientTraceMetadata › pages router › next dev only › soft navigating to a dynamic page should not transform previous propagation data

Failed to start server after 10000ms, waiting for this log pattern: / ✓ Ready in /

  349 |     return setTimeout(() => {
  350 |       reject(
> 351 |         new Error(
      |         ^
  352 |           `Failed to start server after ${ms}ms, waiting for this log pattern: ${this.serverReadyPattern}`
  353 |         )
  354 |       )

  at Timeout._onTimeout (lib/next-modes/base.ts:351:9)

● clientTraceMetadata › pages router › next dev only › soft navigating to a static page should not transform previous propagation data

Failed to start server after 10000ms, waiting for this log pattern: / ✓ Ready in /

  349 |     return setTimeout(() => {
  350 |       reject(
> 351 |         new Error(
      |         ^
  352 |           `Failed to start server after ${ms}ms, waiting for this log pattern: ${this.serverReadyPattern}`
  353 |         )
  354 |       )

  at Timeout._onTimeout (lib/next-modes/base.ts:351:9)

Read more about building and testing Next.js in contributing.md.

@feedthejim feedthejim closed this Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants