-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom direction #80
Add custom direction #80
Conversation
@adsonpleal, this is cool! Thanks for the contribution! 👏🏽 I like the proposal; you can go ahead and polish it. |
@victoreronmosele I've updated the code and the PR description. I think it is good to be reviewed. Let me know if you have any changes request. Also, do you want me to change the "changelog" already? Or do you change it on each release? |
@adsonpleal thanks! I'll do a review shortly and give feedback. For the changelog, the project currently doesn't have one, but I'll add one, and then you can update it with the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adsonpleal thanks for the great work!
I added some requests/suggestions.
@victoreronmosele applied the requested changes. Here a video with the new "custom" behavior, keeping the old state: Screen.Recording.2024-03-27.at.16.37.40.mov |
Thanks for the update @adsonpleal. I'll check out the changes in a few hours. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the wonderful contribution! 🔥
Just have some comments to clarify and this should be merged in soon!
test/ui/widgets/selection_widgets/direction_selection_widget_test.dart
Outdated
Show resolved
Hide resolved
Perfect! Gonna apply the suggestions. |
@victoreronmosele all done! |
Thanks! Merging now. I'll add the changelog in a new PR and include this feature in it. |
Adding the ability to create gradients with custom directions.
Changes:
preview.mov