fix(webhooks): fix duplicate logging (#21)

vincejv · Nov 2, 2022 · c54fe3b · c54fe3b
1 parent fbfc813
commit c54fe3b
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/fpi-bot-api-core/src/main/java/com/abavilla/fpi/bot/processor/MetaMsgEvtPcsr.java b/fpi-bot-api-core/src/main/java/com/abavilla/fpi/bot/processor/MetaMsgEvtPcsr.java
@@ -83,14 +83,11 @@ public Uni<Void> process(MetaMsgEvtDto evt) {
             // process load
             .chain(session -> processLoadQuery(login, session, evt))
             // login failures/query exceptions
-            .onFailure(ApiSvcEx.class).call(ex -> handleApiEx(evt, ex))
-            // failures to send response to messenger
-            .onFailure().invoke(this::handleMsgEx)
-            .replaceWithVoid();
+            .onFailure(ApiSvcEx.class).recoverWithUni(ex -> handleApiEx(evt, ex));
         })
         .onFailure(ex -> ex instanceof MongoWriteException wEx &&
           wEx.getError().getCategory().equals(ErrorCategory.DUPLICATE_KEY))
-        .invoke(throwable ->
+        .recoverWithNull().invoke(throwable ->
           Log.warn("Received duplicate mid: " + evt.getMetaMsgId())
         );
       })
@@ -134,7 +131,8 @@ private Uni<Void> handleApiEx(MetaMsgEvtDto evt, Throwable ex) {
       handleAction = sendMsgrMsg(evt, "Error occurred, please try again");
     }
 
-    return handleAction.chain(() -> metaMsgrSvc.sendTypingIndicator(evt.getSender(), false).replaceWithVoid());
+    return handleAction.chain(() -> metaMsgrSvc.sendTypingIndicator(
+      evt.getSender(), false).replaceWithVoid());
   }
 
   private Uni<Void> sendMsgrMsg(MetaMsgEvtDto evt, String msg) {