feat: update aws arn role block #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. aws arn block is deprecating 2. refactor arn role block into latest format
|
please run |
vincenthsh
changed the title
vincenthsh
reviewed
Mar 19, 2024
Comment on lines
-4
to
+5
| profile: profile | ||
| role: role | ||
| account_id: "12345" |
There was a problem hiding this comment.
this makes sure we hit the case where a role is used (which also requires account_id to be set)
Line 120 in 67c862f
vincenthsh
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes:
This PR modifies the aws arn_role within the s3 backend config. The aws arn_role has been updated with a nested format. This allows follows the updated arn_role format and eliminate the deprecated warnings.