Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add dependency on modules invocation #283

Merged
merged 4 commits into from
Apr 23, 2024
Merged

feat: add dependency on modules invocation #283

merged 4 commits into from
Apr 23, 2024

Conversation

zackhee997
Copy link
Collaborator

@zackhee997 zackhee997 commented Apr 23, 2024 •
edited by vincenthsh
Loading

Add support for depends_on module configuration

Resolves:

@zackhee997 zackhee997 requested a review from vincenthsh as a code owner April 23, 2024 08:17
vincenthsh
vincenthsh approved these changes Apr 23, 2024
View reviewed changes
Copy link
Owner

@vincenthsh vincenthsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'll check out the branch and do the test run against lift&shift just to make sure :D

config/v2/config.go Outdated Show resolved Hide resolved
apply/apply.go Outdated Show resolved Hide resolved
testdata/v2_atlantis_depends_on/terraform/envs/test/vpc/main.tf Show resolved Hide resolved
@vincenthsh vincenthsh changed the title chore: add dependency on modules invocation feat: add dependency on modules invocation Apr 23, 2024
vincenthsh
vincenthsh reviewed Apr 23, 2024
View reviewed changes
plan/plan.go Outdated Show resolved Hide resolved
@vincenthsh vincenthsh merged commit aef1949 into feat-multi-module-components Apr 23, 2024
3 checks passed
@vincenthsh vincenthsh deleted the chore-dependencies-for-module-invocations branch April 23, 2024 10:21
@vincenthsh vincenthsh mentioned this pull request Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincenthsh vincenthsh vincenthsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zackhee997 @vincenthsh