Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate System Info Report #210

Closed
wants to merge 20 commits into from
Closed

Generate System Info Report #210

wants to merge 20 commits into from

Conversation

lunarlattice0
Copy link
Member

This should in theory reduce the workload on helpdesk.

I am so sick of asking "what cpu do you have"....

@lunarlattice0 lunarlattice0 marked this pull request as ready for review October 17, 2023 05:14
Copy link
Member

@apprehensions apprehensions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the error checking is bland, and variable names or code style should be inlign with the Go code style.

Try seeing if there is a library that can provide these sort of features.

cmd/vinegar/vinegar.go Outdated Show resolved Hide resolved
cmd/vinegar/vinegar.go Outdated Show resolved Hide resolved
util/reportinfo.go Outdated Show resolved Hide resolved
util/reportinfo.go Outdated Show resolved Hide resolved
util/reportinfo.go Outdated Show resolved Hide resolved
util/reportinfo.go Outdated Show resolved Hide resolved
Copy link
Member

@apprehensions apprehensions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extract all else to outside the function if clause

cmd/vinegar/vinegar.go Show resolved Hide resolved
@jrelvas-ipc
Copy link
Contributor

Excluding feedback already given and the build error, things are looking good so far.

Not sure if this is going to be included in this PR, but here's some ideas of information we could be including in the future:

  • Vinegar version
  • Last Wine log
  • Output from vulkaninfo(?) - Would be very useful for identifying driver and hardware incompatibilities

@lunarlattice0
Copy link
Member Author

Merged with wael's branch

@apprehensions
Copy link
Member

  • Vinegar version

Unfortunately we had dropped this due to a conflict on how versioning should be handled.

  • Last Wine log

This is definitely possible, but to as this only gains system information, doesn't seem worth it.

  • Output vulkaninfo

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants