-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate System Info Report #210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the error checking is bland, and variable names or code style should be inlign with the Go code style.
Try seeing if there is a library that can provide these sort of features.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extract all else to outside the function if clause
Excluding feedback already given and the build error, things are looking good so far. Not sure if this is going to be included in this PR, but here's some ideas of information we could be including in the future:
|
Merged with wael's branch |
Unfortunately we had dropped this due to a conflict on how versioning should be handled.
This is definitely possible, but to as this only gains system information, doesn't seem worth it.
No |
This should in theory reduce the workload on helpdesk.
I am so sick of asking "what cpu do you have"....