Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiprefix #355

Merged
merged 21 commits into from
Feb 5, 2024
Merged

Multiprefix #355

merged 21 commits into from
Feb 5, 2024

Conversation

apprehensions
Copy link
Member

@apprehensions apprehensions commented Feb 2, 2024 •
edited
Loading

  • State is now a json in the global data directory as oppose to in prefix
  • Switched to log/slog
  • Wineroot is handled exclusively by the wine package and only uses wine64 for wineroot validation.
  • Vinegar says "Goodbye" on successfully running Roblox and quitting.
  • Vinegar sets the message "Oops!" when an error occurs, since an error dialog will appear.
  • Vinegar only makes a splash window in Binary.Main

lunarlattice0
lunarlattice0 reviewed Feb 4, 2024
View reviewed changes
cmd/vinegar/binary.go Outdated Show resolved Hide resolved
lunarlattice0
lunarlattice0 reviewed Feb 4, 2024
View reviewed changes
wine/wine.go
return "", ErrWineRootAbs
}

wine, err := exec.LookPath(filepath.Join(bin, "wine64"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must notify all distributions of this change, some have symlinked wine64 to wine.

lunarlattice0
lunarlattice0 requested changes Feb 4, 2024
View reviewed changes
Copy link
Member

@lunarlattice0 lunarlattice0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check out the comments rq

@apprehensions apprehensions merged commit f58e955 into master Feb 5, 2024
2 checks passed
@apprehensions apprehensions deleted the multiprefix branch February 5, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunarlattice0 lunarlattice0 lunarlattice0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apprehensions @lunarlattice0