Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sober Compatibility issue #467

Closed
wants to merge 1 commit into from
Closed

Conversation

reflexran
Copy link

Make it so by default the outdated Roblox Wine player doesn't get set as the default app for roblox-player, this will prevent it from being launched instead of Sober.

Make it so by default the outdated Roblox Wine player doesn't get set as the default app for roblox-player, this will prevent it from being launched instead of Sober.

Signed-off-by: reflexran <151042611+reflexran@users.noreply.github.com>
@apprehensions
Copy link
Member

This effectively means dropping Player support from Vinegar, which wasn't discussed before hand.

@reflexran
Copy link
Author

reflexran commented Dec 3, 2024

This effectively means dropping Player support from Vinegar, which wasn't discussed before hand.

The player .desktop file is still going to get installed, it's just the mime associations getting deleted. Also I don't see a timeline where bitdancer would allow people to use Wine on the roblox player.

@apprehensions
Copy link
Member

apprehensions commented Dec 6, 2024

it's just the mime associations getting deleted.

Keep in mind this will only affect source installations, because the make mime rule is only ran in source installations. It would make more sense to disable the desktop entirely.

For example, Flatpak automatically adds the associations when it sees the desktop entries.

@apprehensions
Copy link
Member

Implemented in f3261c2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants