fix(types): isTypedArray now performs type narrowing (#3)

visgl · Jul 12, 2024 · 6b1f058 · 6b1f058
1 parent d9cb58f
commit 6b1f058
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/modules/core/src/index.ts b/modules/core/src/index.ts
@@ -1,7 +1,7 @@
 // luma.gl, MIT license
 
 // types
-export type {TypedArray, NumericArray} from '@math.gl/types';
+export type {TypedArray, TypedArrayConstructor, NumberArray, NumericArray} from '@math.gl/types';
 
 export type {isTypedArray, isNumericArray} from '@math.gl/types';
 

diff --git a/modules/types/src/is-array.ts b/modules/types/src/is-array.ts
@@ -5,18 +5,18 @@ import {TypedArray, NumericArray} from './array-types';
  * @param value value to be tested
  * @returns input as TypedArray, or null
  */
-export function isTypedArray(value: unknown): TypedArray | null {
-  return ArrayBuffer.isView(value) && !(value instanceof DataView) ? (value as TypedArray) : null;
+export function isTypedArray(value: unknown): value is TypedArray {
+  return ArrayBuffer.isView(value) && !(value instanceof DataView);
 }
 
 /**
  * Check is an array is a numeric array (typed array or array of numbers)
  * @param value value to be tested
  * @returns input as NumericArray, or null
  */
-export function isNumericArray(value: unknown): NumericArray | null {
+export function isNumericArray(value: unknown): value is NumericArray {
   if (Array.isArray(value)) {
-    return value.length === 0 || typeof value[0] === 'number' ? (value as number[]) : null;
+    return value.length === 0 || typeof value[0] === 'number';
   }
   return isTypedArray(value);
 }