Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dev tools #26

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Upgrade dev tools #26

merged 3 commits into from
Aug 27, 2024

Conversation

Pessimistress
Copy link
Contributor

Test new @vis.gl/dev-tools module

@Pessimistress Pessimistress requested a review from ibgreen August 26, 2024 22:35
@coveralls
Copy link

coveralls commented Aug 26, 2024

Pull Request Test Coverage Report for Build 10584903966

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.957%

Totals Coverage Status
Change from base Build 10568286294: 0.0%
Covered Lines: 14805
Relevant Lines: 17576

💛 - Coveralls

package.json Outdated
@@ -27,7 +27,8 @@
"@probe.gl/bench": "^4.0.0",
"@turf/destination": "^6.0.1",
"@types/tape-promise": "^4.0.1",
"ocular-dev-tools": "2.0.0-alpha.34",
"@vis.gl/dev-tools": "1.0.0-alpha.7",
"@vis.gl/ts-plugins": "1.0.0-alpha.7",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a usability advantage to requiring apps to manage two separate imports? Or could dev-tools depend on/re-export ts-plugins directly?

@@ -64,7 +64,19 @@
"@math.gl/web-mercator/*": ["modules/web-mercator/src/*"],
"@math.gl/web-mercator/test/*": ["modules/web-mercator/test/*"],
"test/*": ["test/*"]
}
},
"plugins": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be managed with some "extend": "..." syntax so that we don't need to duplicate this everywhere?

@Pessimistress Pessimistress merged commit 78c0ee4 into master Aug 27, 2024
1 check passed
@Pessimistress Pessimistress deleted the x/dev-tools branch August 27, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants