Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly report "skipped" result in TestCase #7067

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Dec 11, 2024

Description

I'm also wondering if we should remove the skipped state altogether from the result() and only keep pass and fail 🤔

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Dec 11, 2024

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 54bdfb1
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/67595cf3d7adfc0008fb25a2
😎 Deploy Preview https://deploy-preview-7067--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sheremet-va
Copy link
Member Author

Decided to introduce the state() method on Suite and Module instead (similar to result() but without the errors): https://github.com/vitest-dev/vitest/pull/7069/files#diff-cd81764fa6513d3cb255c7299d25deeef63f842e17877bfc16ff9a75c783ddf6R356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants