Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: update fake-timers to v14.0.0 #7097

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

xxzefgh
Copy link

@xxzefgh xxzefgh commented Dec 18, 2024

Description

Update @sinonjs/fake-timers to latest version and add support for node:timers/promises module.

  • Updated patches
  • Enabled new ignoreMissingTimers option by default as it better reflects previous behavior
  • Removed setImmediate/clearImmediate workaround as it has been fixed AFAIK
  • Updated existing tests to include all timers in global object as this behavior has changed in this commit (sinonjs/fake-timers@3412033)

I haven't added any new tests due to these checks making it difficult (not possible?):
permalink

        if (_global === globalObject && timersModule) {
            clock.timersModuleMethods = [];
        }
        if (_global === globalObject && timersPromisesModule) {
            clock.timersPromisesModuleMethods = [];
        }

Partially fixes #3088

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

- Support node:timers/promises

Signed-off-by: Mirza Brunjadze <brunjadzem@gmail.com>
Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3f3d3cb
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/67624ced81066b0008321597
😎 Deploy Preview https://deploy-preview-7097--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fake timers do not mock AbortSignal.timeout or timers/promises
1 participant