feat: make json reporter easier to extend #7103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
separates concerns : generating results and writing results should be separate functions
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
sheremet-va
requested changes
Dec 23, 2024
| @@ -88,7 +88,7 @@ export class JsonReporter implements Reporter { | |||
| this.start = Date.now() | |||
| } | |||
|
|
|||
| protected async logTasks(files: File[], coverageMap?: CoverageMap | null) { | |||
| protected async logTasks(files: File[], coverageMap?: CoverageMap | null): Promise<JsonTestResults> { | |||
There was a problem hiding this comment.
logTasks no longer logs tasks. Should we change a name?
There was a problem hiding this comment.
yeah... it generates the logs, it just leaves writing up to the caller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Separates concerns : generating results and writing results should be separate functions.
This way we can extend the logtasks function to change the coverage map results without touching the write logic.
Or the other way, change the writing logic without touching the coverage map logic.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.