Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use tinyglobby instead of fast-glob in Vitest #7105

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented Dec 19, 2024

This reverts commit 70baaaa.

Description

Discussed here: #6688 (comment)

This needs some changes in tinyglobby that have not yet been released, so I'm leaving this in draft mode

There are a couple of things I'm surprised by:

  • why building updated the packages/ui/client/auto-imports.d.ts file
  • why lint is failing on spacing issues on a bunch of files I didn't touch

Please feel free to push any changes to do necessary cleanups or to create your own PR. This PR isn't quite ready, but I hope it's at least saved some effort in starting to put together the PR

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a3b0c4d
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/6769b66eac8b96000808db23
😎 Deploy Preview https://deploy-preview-7105--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AriPerkkio
Copy link
Member

why lint is failing on spacing issues on a bunch of files I didn't touch

The lockfile contains plenty of changes, including updating @antfu/eslint-config which is likely causing the lint errors. Please stage only the specific lines of lockfile to avoid such errors.

@benmccann benmccann force-pushed the tinyglobby branch 7 times, most recently from f0afc2e to 37b9914 Compare December 19, 2024 19:40
@benmccann
Copy link
Contributor Author

The lockfile contains plenty of changes, including updating @antfu/eslint-config which is likely causing the lint errors. Please stage only the specific lines of lockfile to avoid such errors.

Thanks! That suggestion helped a lot and fixed the issue. I was surprised it was updating other things, but I guess that happened since this PR started by reverting another one, so thanks for catching it!

@benmccann benmccann marked this pull request as draft December 20, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants