-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump @types/chai to 5.0.1 #7123
base: main
Are you sure you want to change the base?
Conversation
note: I haven't actually checked if the typings work now, but based on a simple diff between v4 and v5, I concluded that bumping the version will fix the issue |
welp ci is breaking, idk y |
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
ci based tdd |
This reverts commit cced3ff.
found out the type issue Caused by this commit 5f4774f I am not sure why he is inlining chai types when he already patched it? anyway, this is out of my decision. This was not an issue in the previous 4.3.6 declare namespace Chai { 5.0.1 declare global {
namespace Chai { @sheremet-va I would like to know how you would approach this issue also I am not willing to fix the failing test as I have no idea why it fails |
Hey, thanks for bringing the PR 👋 The idea of not having Though patch is getting uglier, the basic typing should be working like before https://stackblitz.com/edit/vitest-dev-vitest-xrmchgds?file=test%2Fbasic.test.ts |
@vitest/browser
@vitest/coverage-istanbul
@vitest/expect
@vitest/coverage-v8
@vitest/mocker
@vitest/pretty-format
@vitest/runner
@vitest/snapshot
@vitest/spy
@vitest/ui
@vitest/utils
vite-node
vitest
@vitest/web-worker
@vitest/ws-client
commit: |
Description
#7121 cc @hi-ogawa
fix broken vitest assert types
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
. (vitest/test/config/fixtures/exec-args-fixtures/vmThreads.test.ts
fails for some reason)Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.