Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: skip vue v8 coverage test on Vite 6 #7124

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Dec 24, 2024

Description

(EDIT: a following issue is fixed in #7125)

Additionally, typecheck mode's // @ts-expect-error is failing now but this seems due to a flaw on Vitest side since comment is stripped in generated code, so generatedPositionFor here won't work.

? generatedPositionFor(traceMap, {
line: originalError.line,
column: originalError.column,
source: basename(path),
})

Previously, it was working due to the fallback logic happens to stay within the specific generated code, which now breaks due to slight change of new lines in ssr transform.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Dec 24, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit fe9fc54
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/676a4da6604ca50008e5ab58
😎 Deploy Preview https://deploy-preview-7124--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant