Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: File.getUploadURL() #1050

Merged
merged 12 commits into from
Mar 8, 2024
Merged

refactor: File.getUploadURL() #1050

merged 12 commits into from
Mar 8, 2024

Conversation

phorward
Copy link
Member

This pull request is focuesed to (partly) fix #1017.

@phorward phorward added viur-meeting Issues to discuss in the next ViUR meeting refactoring Pull requests that refactor code but do not change its behavior. labels Jan 31, 2024
@sveneberth
Copy link
Member

viur meeting result:

@phorward phorward removed the viur-meeting Issues to discuss in the next ViUR meeting label Feb 2, 2024
@phorward phorward added this to the ViUR-core v3.6 milestone Feb 13, 2024
@phorward
Copy link
Member Author

phorward commented Mar 2, 2024 •
edited
Loading

https://stackoverflow.com/a/31976060/3749896

I've created a regex for this, which should work: https://regex101.com/r/faUewi/1

re = r"^(?!^(CON|PRN|AUX|NUL|COM[1-9]|LPT[1-9])$)[^\x00-\x1F<>:\"\/\\|?*]*[^\x00-\x1F<>:\"\/\\|?*. ]$"gm

@phorward phorward marked this pull request as ready for review March 4, 2024 16:55
@phorward phorward added bug(fix) Something isn't working or address a specific issue or vulnerability Priority: High After critical issues are fixed, these should be dealt with before any further issues. labels Mar 4, 2024
@phorward phorward mentioned this pull request Mar 4, 2024
Closed
ArneGudermann
ArneGudermann requested changes Mar 6, 2024
View reviewed changes
src/viur/core/modules/file.py Show resolved Hide resolved
src/viur/core/modules/file.py Show resolved Hide resolved
@phorward phorward requested a review from ArneGudermann March 7, 2024 12:15
ArneGudermann
ArneGudermann previously approved these changes Mar 7, 2024
View reviewed changes
sveneberth
sveneberth requested changes Mar 8, 2024
View reviewed changes
src/viur/core/modules/file.py Outdated Show resolved Hide resolved
@phorward @sveneberth
Check filename accordingly
fa70684 
Co-authored-by: Sven Eberth <mail@sveneberth.de>
@phorward phorward requested a review from sveneberth March 8, 2024 20:28
@phorward phorward merged commit 35cbf95 into viur-framework:develop Mar 8, 2024
3 checks passed
@phorward phorward added the viur-meeting Issues to discuss in the next ViUR meeting label Mar 12, 2024
@ArneGudermann ArneGudermann mentioned this pull request Mar 15, 2024
Merged
phorward pushed a commit that referenced this pull request Mar 15, 2024
@ArneGudermann
fix: file module typo UnprocessableEntity (#1105)
80b9319 
fix for #1050
@sveneberth sveneberth removed the viur-meeting Issues to discuss in the next ViUR meeting label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sveneberth sveneberth sveneberth approved these changes

@ArneGudermann ArneGudermann ArneGudermann left review comments

Assignees
No one assigned
Labels
bug(fix) Something isn't working or address a specific issue or vulnerability Priority: High After critical issues are fixed, these should be dealt with before any further issues. refactoring Pull requests that refactor code but do not change its behavior.
Projects
Documentation
Status: Todo
Milestone
ViUR-core v3.6
Development

Successfully merging this pull request may close these issues.
3 participants
@phorward @sveneberth @ArneGudermann