Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tr_key maybe empty in existing database #1095

Closed

Conversation

phorward
Copy link
Member

There is a VIUR project which already uses translations, so there are existing entities, but the tr_key does not exist. This fix handles this specific case.

There is a VIUR project which already uses translations, so there are existing entities, but the tr_key does not exist. This fix handles this specific case.
@phorward phorward requested a review from sveneberth March 11, 2024 22:44
@phorward phorward added this to the ViUR-core v3.6 milestone Mar 12, 2024
@phorward phorward added the bug(fix) Something isn't working or address a specific issue or vulnerability label Mar 12, 2024
@sveneberth
Copy link
Member

Did the deferred task not work for you?

https://github.com/viur-framework/viur-core/blob/develop/src/viur/core/i18n.py#L439

@phorward phorward changed the title fix: tr_key maybe empty in existing database fix: tr_key maybe empty in existing database Mar 12, 2024
@sveneberth sveneberth added the viur-meeting Issues to discuss in the next ViUR meeting label Mar 13, 2024
@phorward phorward removed the viur-meeting Issues to discuss in the next ViUR meeting label Mar 15, 2024
@phorward
Copy link
Member Author

The problem was not reproducible, therefore we're closing it for now.

@phorward phorward closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug(fix) Something isn't working or address a specific issue or vulnerability
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants