Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(breakingchange): ✨ add breaking change configuration #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(breakingchange): ✨ add breaking change configuration #101

wants to merge 1 commit into from

Conversation

yi-Xu-0100
Copy link
Collaborator

@yi-Xu-0100 yi-Xu-0100 commented Mar 24, 2021 •
edited
Loading

  1. add detectBreakingChange option.
  2. add promptBreakingChange option.
  3. add breakingChangeFormat option.
  4. fix the prompt context retaining issue.

close #39, close #100

@yi-Xu-0100 yi-Xu-0100 requested a review from vivaxy March 24, 2021 08:54
@yi-Xu-0100 yi-Xu-0100 added the wait-to-build PR wait to build package. label Mar 24, 2021
@yi-Xu-0100 yi-Xu-0100 linked an issue Mar 24, 2021 that may be closed by this pull request
[BUG] If the promptScopes changed, the context of scope will be retained #100
Closed
@github-actions
Copy link
Contributor

The beta extension of this pull has been built in the workflow! 🎉
Download vscode-conventional-commits-10f57b7.vsix in artifacts. 🚀

@github-actions github-actions bot removed the wait-to-build PR wait to build package. label Mar 24, 2021
@yi-Xu-0100 yi-Xu-0100 removed a link to an issue Mar 24, 2021
[BUG] If the promptScopes changed, the context of scope will be retained #100
Closed
vivaxy
vivaxy reviewed Mar 24, 2021
View reviewed changes
Copy link
Owner

@vivaxy vivaxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 That's a lot work done here. I'd like to test it for some time.

src/lib/prompts.ts Outdated Show resolved Hide resolved
@yi-Xu-0100
Copy link
Collaborator Author

@vivaxy I test many times today and will use it in the future for some time. During the test, I found the bug (#100). I try to delete the export function and use the constructor in the prompt function to fix the bug.

I do not why it can work, but it fixes the issue. Maybe we can make this little commit merge into master and make a patch firstly. See more in (#100) and the commit (326c953). 😀

vivaxy
vivaxy reviewed Mar 24, 2021
View reviewed changes
package.nls.json Outdated
"extension.sources.prompt.breakingChange.placeholder": "Select a way to add breaking changes of this change.",
"extension.sources.prompt.breakingChange.noneItem.label": "None",
"extension.sources.prompt.breakingChange.noneItem.detail": "No breaking change.",
"extension.sources.prompt.breakingChange.pointItem.label": "! (point mode)",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this called point mode?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it can be called as Breaking change in header.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

! exclamation mark (英式英语) / point (美式英语)

I misunderstood it. The exclamation point may be correct. 😅

I will use Breaking change in header, Breaking change in footer and Breaking change as token in footer for the labels of them.

@vivaxy
Copy link
Owner

vivaxy commented Mar 24, 2021 •
edited
Loading

@vivaxy I test many times today and will use it in the future for some time. During the test, I found the bug (#100). I try to delete the export function and use the constructor in the prompt function to fix the bug.

I do not why it can work, but it fixes the issue. Maybe we can make this little commit merge into master and make a patch firstly. See more in (#100) and the commit (326c953). 😀

Maybe because commitMessage is in singleton, and the extension does not exit after committing. We can check the output to make sure. If so, it's a nice fix.

@yi-Xu-0100
feat(breakingchange): ✨ add breaking change section
21f24f5 
1. add `detectBreakingChange` option.
2. add `promptBreakingChange` option.
3. add two `breakingChangeFormat`.
@yi-Xu-0100 yi-Xu-0100 force-pushed the add-breaking-change-prompt branch from a42c75b to 21f24f5 Compare April 13, 2021 05:01
@silopolis
Copy link

Any chance of this getting merged someday ?

@vladly
Copy link

vladly commented May 10, 2023

Please add this feature

@yi-Xu-0100
Copy link
Collaborator Author

yi-Xu-0100 commented May 26, 2023 •
edited
Loading

👋 @silopolis @vladly I'm glad you noticed this issue. It hasn't been updated in a long time, and fixing it will require some time. Currently, I don't have the leisure time to address this problem. If you have any ideas, you can submit a pull request to help with the development. 😊

Moreover, due to the long-term use of the extension, frequent commits with disruptive changes are unreasonable. Therefore, this pull request has been put on hold and considered a low-priority feature. 🤔

@leonardvgend
Copy link

Hello, if I understand correctly, this change will autmoatically add "BREAKING CHANGE: " when the user enters their breaking change into this prompt?

image

If so, this would be an amazing feature! I actually expected it to work like that already, and I thought something might be wrong with my configs.

@sag1v
Copy link

sag1v commented Feb 12, 2024

Hi, is this going to be merged soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivaxy vivaxy vivaxy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@yi-Xu-0100 @vivaxy @silopolis @vladly @leonardvgend @sag1v