Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch sub-config with no IP assignment bug #1178

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

ksamoray
Copy link
Collaborator

@ksamoray ksamoray commented Apr 9, 2024

When a switch sub-config is created with no specification of IP assignment, the code mishandles it and tries set it anyway.

Copy link
Member

@salv-orlando salv-orlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

When a switch sub-config is created with no specification of IP
assignment, the code mishandles it and tries set it anyway.

Signed-off-by: Kobi Samoray <kobi.samoray@broadcom.com>
@ksamoray ksamoray force-pushed the subcfg_ip_assignment_nil branch from b59fc31 to 19bfa6a Compare April 9, 2024 08:46
@ksamoray
Copy link
Collaborator Author

ksamoray commented Apr 9, 2024

/test-all

@ksamoray ksamoray merged commit d8f4f3c into vmware:master Apr 9, 2024
7 checks passed
@ksamoray ksamoray deleted the subcfg_ip_assignment_nil branch April 9, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants