Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace deprecated type schema.ImportStatePassthrough #1435

Closed
wants to merge 1 commit into from

Conversation

tenthirtyam
Copy link
Collaborator

Summary of Pull Request

The type schema.ImportStatePassthrough has been deprecated in favour of schema.ImportStatePassthroughContext in the SDK helper/schema.

References:

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style/formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Test and Documentation Coverage

For bug fixes or features:

  • Tests have been completed.
  • Documentation has been added/updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

The type `schema.ImportStatePassthrough` has been deprecated in favour of `schema.ImportStatePassthroughContext` in the SDK `helper/schema`.

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@tenthirtyam tenthirtyam added dependencies Dependencies technical-debt Technical Debt chore Chore labels Oct 16, 2024
@tenthirtyam tenthirtyam self-assigned this Oct 16, 2024
@tenthirtyam tenthirtyam added needs-review Needs Review size/m Relative Sizing: medium labels Oct 16, 2024
Copy link
Member

@salv-orlando salv-orlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we have a large feature branch that needs to be merged back in master, it might be worth applying commit like this once we merge the feature branch - and of course implementing the same changes there too.

@tenthirtyam tenthirtyam marked this pull request as draft November 21, 2024 02:04
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Dec 11, 2024
@vmware vmware locked and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
chore Chore dependencies Dependencies size/m Relative Sizing: medium technical-debt Technical Debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants