Vpc branch merge #1482
Merged
Vpc branch merge #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anna Khmelnitsky <akhmelnitsky@vmware.com>
Signed-off-by: Kobi Samoray <ksamoray@vmware.com>
Revise GitHub actions files to run on feature branches
Signed-off-by: Anna Khmelnitsky <akhmelnitsky@vmware.com>
nsxt_policy_vpc datasource has been renamed to nsxt_vpc Signed-off-by: Kobi Samoray <kobi.samoray@broadcom.com>
Switch to updated temporary SDK
Fix VPC documentation with correct DS name
VPC datasource test is failing as the context block shouldn't have the VPC itself Signed-off-by: Kobi Samoray <kobi.samoray@broadcom.com>
This would apply to all resources that inherit from ManagedResource object. Length limits are taked from NSX spec and are enforced by NSX, hence we're not breaking backwards compatibility for valid terraform configs. Signed-off-by: Anna Khmelnitsky <akhmelnitsky@vmware.com>
Fix failing tests on vpc20 branch
Generated with command line params below: GatewayConnection --no-api-wrapper Signed-off-by: Kobi Samoray <ksamoray@vmware.com>
Signed-off-by: Anna Khmelnitsky <akhmelnitsky@vmware.com>
Signed-off-by: Kobi Samoray <kobi.samoray@broadcom.com>
Test for this data source is covered together with VPC group resource test. Signed-off-by: Anna Khmelnitsky <akhmelnitsky@vmware.com>
Gateway connection resource for VPC v2.0
Add new member types to group criteria
Add VPC group data source
Signed-off-by: Kobi Samoray <kobi.samoray@broadcom.com>
To avoid entry of invalid ids to the context fields. Signed-off-by: Kobi Samoray <kobi.samoray@broadcom.com>
Extended tests will be added as follow up Signed-off-by: Anna Khmelnitsky <akhmelnitsky@vmware.com>
Vpc20 service profile support
Signed-off-by: Anna Khmelnitsky <akhmelnitsky@vmware.com>
Update temporary SDK
Fix nsxt_vpc_group datasource documentation
Add id field validator and apply to context ids
Signed-off-by: Kobi Samoray <kobi.samoray@broadcom.com>
Signed-off-by: Kobi Samoray <kobi.samoray@broadcom.com>
Fix VPC datasource doc category
Signed-off-by: Anna Khmelnitsky <akhmelnitsky@vmware.com>
Fixes in VPC documentation
Remove context from transit gateway attachment resource
Clarify VPC group documentation
nsxt_policy_project has a default_security_profile attribute but it was not handled correctly in read operation. Signed-off-by: Kobi Samoray <kobi.samoray@broadcom.com>
Handle default_security_profile attribute in project read func
This is the new way of attaching connectivity profile to vpc, hence the profile attribute is also removed from vpc resource Signed-off-by: Anna Khmelnitsky <akhmelnitsky@vmware.com>
Add VPC attachment resource
Path parsing func parseStandardPolicyPath() didn't handle well project paths, seems like it could only handle sub-project objects. Signed-off-by: Kobi Samoray <kobi.samoray@broadcom.com>
Handle project path parsing properly
Signed-off-by: Anna Khmelnitsky <akhmelnitsky@vmware.com>
Adjust to DHCP changes in service and subnet
Signed-off-by: Anna Khmelnitsky <akhmelnitsky@vmware.com>
Fix formatting
This follows fix on NSX Signed-off-by: Anna Khmelnitsky <akhmelnitsky@vmware.com>
Allow updating IP allocation under project or VPC
Signed-off-by: Anna Khmelnitsky <akhmelnitsky@vmware.com>
|
@annakhm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
|
@annakhm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Signed-off-by: Anna Khmelnitsky <akhmelnitsky@vmware.com>
|
@annakhm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
This has been broken, as the importer helper did not return the schema when it was detected that the parameter isn't a policy path. Signed-off-by: Kobi Samoray <kobi.samoray@broadcom.com>
|
@annakhm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
This is relevant for NSX 9.0.0 onwards. In addition, mark `default_security_profile` as Computed to avoid non-empty diff. Signed-off-by: Anna Khmelnitsky <akhmelnitsky@vmware.com>
|
@annakhm, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges VPC related work that was developed under
vpc-feature-branchback to master