Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove member type validation in group criteria #1496

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

annakhm
Copy link
Collaborator

@annakhm annakhm commented Jan 3, 2025

This follows NSX allowing mixing some member types within same expression block, which was not allowed earlier.

Rather then following NSX validation for which member types mixes are permitted, terraform will let NSX do the validation for this part. Other validations on terraform side - such as same expression type - are not affected by this change.

This follows NSX allowing mixing some member types within
same expression block, which was not allowed earlier.

Rather then following NSX validation for which member types mixes are
permitted, terraform will let NSX do the validation for this part.
Other validations on terraform side - such as same expression type -
are not affected by this change.

Signed-off-by: Anna Khmelnitsky <akhmelnitsky@vmware.com>
@annakhm annakhm linked an issue Jan 3, 2025 that may be closed by this pull request
@annakhm
Copy link
Collaborator Author

annakhm commented Jan 3, 2025

--- PASS: TestAccResourceNsxtPolicyGroup_empty (11.29s)
--- PASS: TestAccResourceNsxtPolicyGroup_mixedCriteria (21.04s)
--- PASS: TestAccResourceNsxtPolicyGroup_basicImport (24.25s)
--- PASS: TestAccResourceNsxtPolicyGroup_groupTypeIPAddressCriteria (33.46s)
--- PASS: TestAccResourceNsxtPolicyGroup_nestedCriteria (33.54s)
--- PASS: TestAccResourceNsxtPolicyGroup_multipleIPAddressCriteria (33.74s)
--- PASS: TestAccResourceNsxtPolicyGroup_multipleCriteria (34.56s)
--- PASS: TestAccResourceNsxtPolicyGroup_addressCriteria (34.64s)
--- PASS: TestAccResourceNsxtPolicyGroup_pathCriteria (50.44s)
--- PASS: TestAccResourceNsxtPolicyGroup_identityGroup (56.32s)
--- PASS: TestAccResourceNsxtPolicyGroup_multipleNestedCriteria (56.71s)

@annakhm
Copy link
Collaborator Author

annakhm commented Jan 3, 2025

--- PASS: TestAccResourceNsxtPolicyGroup_empty_multitenancy (8.41s)
--- PASS: TestAccDataSourceNsxtPolicyGroup_multitenancy (16.80s)
--- PASS: TestAccResourceNsxtPolicyGroup_basicImport_multitenancy (24.38s)
--- PASS: TestAccResourceNsxtPolicyGroup_addressCriteria_multitenancy (34.32s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nsxt_policy_group member_type policy evolve
1 participant