fix: missing vmnic info with r/cluster import

[burnsjared0415]

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

Fix missing vmnic info with r/cluster import.

Type of Pull Request

• This is a bug fix.
• This is an enhancement or feature.
• This is a code style/formatting update.
• This is a documentation update.
• This is a refactoring update.
• This is a chore update
• This is something else.
  Please describe:

Related to Existing Issues

Ref: #210

Test and Documentation Coverage

For bug fixes or features:

• Tests have been completed.
• Documentation has been added/updated.

Breaking Changes?

• Yes, there are breaking changes.
• No, there are no breaking changes.

[tenthirtyam]

Just a small change to add it back.

Could you also share the result and state in the testing section?

[dimitarproynov]

I don't see any tests that verify that the vmnic attribute is set on cluster's hosts.

[tenthirtyam]

@burnsjared0415 could you address the following issues from the linter and check to see if this can be addressed in the test based on Dimitar's comment.

  Error: internal/cluster/cluster_operations.go:393:17: ineffectual assignment to err (ineffassign)
  	clusterResult, err := apiClient.Clusters.GetCluster(getClusterParams)
  	               ^
  Error: internal/cluster/cluster_operations.go:406:22: ineffectual assignment to err (ineffassign)
  	flattenedHostSpecs, err := getFlattenedHostSpecsForRefs(ctx, clusterObj.Hosts, apiClient)

[tenthirtyam]

Rebased based on the changes to main recently. Needs testing again.

[tenthirtyam]

Repeated code block.

[tenthirtyam]

You might also consider the following:

func FlattenHost(host vcf.Host) map[string]interface{} {
	result := make(map[string]interface{})
	result["id"] = host.Id
	result["host_name"] = host.Fqdn

	if host.IpAddresses != nil {
		ipAddresses := *host.IpAddresses
		if len(ipAddresses) > 0 {
			result["ip_address"] = ipAddresses[0].IpAddress
		}
	}

	if host.PhysicalNics != nil {
		var physicalNics []map[string]interface{}
		for _, nic := range host.PhysicalNics {
			nicMap := make(map[string]interface{})
			nicMap["name"] = nic.DeviceName
			nicMap["mac_address"] = nic.MacAddress
			physicalNics = append(physicalNics, nicMap)
		}
		result["vmnic"] = physicalNics
	}

	return result
}

[tenthirtyam]

Found some repeated logic.

[tenthirtyam]

You might also consider the following:

func FlattenHost(host vcf.Host) map[string]interface{} {
	result := make(map[string]interface{})
	result["id"] = host.Id
	result["host_name"] = host.Fqdn

	if host.IpAddresses != nil {
		ipAddresses := *host.IpAddresses
		if len(ipAddresses) > 0 {
			result["ip_address"] = ipAddresses[0].IpAddress
		}
	}

	if host.PhysicalNics != nil {
		var physicalNics []map[string]interface{}
		for _, nic := range host.PhysicalNics {
			nicMap := make(map[string]interface{})
			nicMap["name"] = nic.DeviceName
			nicMap["mac_address"] = nic.MacAddress
			physicalNics = append(physicalNics, nicMap)
		}
		result["vmnic"] = physicalNics
	}

	return result
}