Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small issues #904

Merged
merged 8 commits into from
Jan 3, 2025
Merged

Small issues #904

merged 8 commits into from
Jan 3, 2025

Conversation

gerouvi
Copy link
Collaborator

@gerouvi gerouvi commented Dec 30, 2024 •
edited
Loading

  • Made the process create inputs labels in bold.
  • Updated the delete button for questions.
  • Removed text variants.
  • Adjusted process mobile tabs to occupy 100% width.
  • Changed the disabled input in the share modal to read-only.
  • Aligned the dashboard back button with the title.
  • Removed Badge display flex

@gerouvi gerouvi requested a review from elboletaire December 31, 2024 09:35
elboletaire
elboletaire requested changes Dec 31, 2024
View reviewed changes
Copy link
Member

@elboletaire elboletaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo the remove button position change and update the code with develop. The changes to the remove button when questions.length < 2 were done in a separate PR yesterday, and its position should not have been changed.

src/components/ProcessCreate/Questions/Question.tsx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025 •
edited
Loading

🚀 Deployed on https://6777b8684e3074975fe332da--vocdoni-app-dev.netlify.app

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025 •
edited
Loading

🚀 Deployed on https://6777b86963703bcaed0d2489--vocdoni-app-stg.netlify.app

@github-actions github-actions bot temporarily deployed to pull request January 2, 2025 20:47 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 2, 2025 20:47 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 2, 2025 22:12 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 2, 2025 22:12 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 3, 2025 09:27 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 3, 2025 09:27 Inactive
@gerouvi gerouvi requested a review from elboletaire January 3, 2025 09:35
@github-actions github-actions bot temporarily deployed to pull request January 3, 2025 10:08 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 3, 2025 10:08 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 3, 2025 10:14 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 3, 2025 10:14 Inactive
@elboletaire elboletaire merged commit c4b168b into develop Jan 3, 2025
3 checks passed
@elboletaire elboletaire deleted the b/small-fixes branch January 3, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elboletaire elboletaire elboletaire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gerouvi @elboletaire