Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tables #907

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Tables #907

wants to merge 3 commits into from

Conversation

gerouvi
Copy link
Collaborator

@gerouvi gerouvi commented Dec 30, 2024

Fixed issue with tables and striped variant in dashboard processes

Copy link

github-actions bot commented Dec 30, 2024

@github-actions github-actions bot temporarily deployed to pull request December 30, 2024 18:21 Inactive
Copy link

github-actions bot commented Dec 30, 2024

@github-actions github-actions bot temporarily deployed to pull request December 30, 2024 18:21 Inactive
@gerouvi gerouvi requested a review from elboletaire December 31, 2024 09:35
Copy link
Member

@elboletaire elboletaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colors do not match the designs

imatge

designs:
imatge
imatge

Also, remember to recover the hover effect on rows.

@github-actions github-actions bot temporarily deployed to pull request January 2, 2025 21:56 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 2, 2025 21:56 Inactive
Copy link
Member

@elboletaire elboletaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still with issues...
imatge
There's only a single border visible in the middle of the table, every row should have a border from what I can see in the original design. The colors aren't the same, the ones here are lighter (#fdfdfd) than the ones in the design (#fcfcfc). Also, I'm not sure we want the header in white, although that's one of the possibilities in the design.

Please also check this table where there's a border appearing unaligned to the other ones (under subscription section):
imatge

@gerouvi gerouvi requested a review from elboletaire January 7, 2025 10:28
@github-actions github-actions bot temporarily deployed to pull request January 7, 2025 10:28 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants