Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beaker: Set job-specific domain #22

Merged
merged 1 commit into from
Feb 9, 2023
Merged

beaker: Set job-specific domain #22

merged 1 commit into from
Feb 9, 2023

Conversation

bastelfreak
Copy link
Member

The used domain for beaker instances is now unique for each workflow run for each module we have.

@bastelfreak bastelfreak requested a review from ekohl December 12, 2022 13:50
Copy link
Member

@root-expert root-expert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably ${{ github.run_attempt }} is a little bit overkill but it doesn't make any difference so 🤷‍♂️

@bastelfreak
Copy link
Member Author

@root-expert the idea is to create a domain that's unique across our whole organisation across all CI runs. run_attempt is required to ensure uniqueness across job restarts for the same PR.

.github/workflows/beaker.yml Show resolved Hide resolved
The used domain for beaker instances is now unique for each workflow run
for each module we have.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants