Skip to content

Commit

Permalink
Finalize remove mixed types
Browse files Browse the repository at this point in the history
  • Loading branch information
vpietri committed Dec 2, 2024
1 parent 56737ba commit c46e17a
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 17 deletions.
4 changes: 1 addition & 3 deletions Block/Tab/Panel.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,9 @@ public function __construct(
}

/**
* Used only in phtml
*
* @param $key
* @param $index
* @return array|\Magento\Framework\DataObject|mixed|string|null
* @return array|\Magento\Framework\DataObject|string|null
* @throws \Exception
*/
public function getData($key = '', $index = null)
Expand Down
19 changes: 11 additions & 8 deletions Helper/Register.php
Original file line number Diff line number Diff line change
Expand Up @@ -103,53 +103,56 @@ public function getContextData()
}

/**
* @return mixed
* @return \Magento\Framework\DataObject|null
*/
public function getObservers()
{
return $this->getRegisteredData('observers');
}

/**
* @return mixed
* @return \Magento\Framework\DataObject|null
*/
public function getEvents()
{
return $this->getRegisteredData('events');
}

/**
* @return mixed
* @return \Magento\Framework\DataObject|null
*/
public function getCollections()
{
return $this->getRegisteredData('collections');
}
/**
* @return array
*/

/**
* @return mixed
* @return \Magento\Framework\DataObject|null
*/
public function getModels()
{
return $this->getRegisteredData('models');
}

/**
* @return mixed
* @return \Magento\Framework\DataObject|null
*/
public function getBlocks()
{
return $this->getRegisteredData('blocks');
}

/**
* @return \Magento\Framework\DataObject|null
*/
public function getLayoutHandles()
{
return $this->getRegisteredData('layout_handles');
}

/**
* @return \Magento\Framework\DataObject|null
*/
public function getLayoutHierarchy()
{
return $this->getRegisteredData('layout_tree_blocks_hierarchy');
Expand Down
2 changes: 1 addition & 1 deletion Observer/LayoutGenerateBlocksAfterObserver.php
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public function execute(Observer $observer)

/**
* @param \Magento\Framework\View\LayoutInterface $layout
* @return mixed
* @return array
*/
protected function getHandles($layout)
{
Expand Down
3 changes: 1 addition & 2 deletions Plugin/Framework/App/Cache.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,13 @@ public function beforeLoad(CacheInterface $subject, string $identifier)
$this->cacheService->addCache('load', $identifier);
}


/**
* @param CacheInterface $subject
* @param string $data
* @param string $identifier
* @param array $tags
* @param $lifeTime
* @return mixed
* @return void
*/
public function beforeSave(
CacheInterface $subject,
Expand Down
7 changes: 4 additions & 3 deletions Plugin/PageCache/FrontController/BuiltinPlugin.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,14 @@ class BuiltinPlugin
*/
private $cacheService;

/**
* @param \ADM\QuickDevBar\Service\App\Cache $cacheService
*/
public function __construct(\ADM\QuickDevBar\Service\App\Cache $cacheService)
{
$this->cacheService = $cacheService;
}


/**
* @param PageCache $subject
* @param string $identifier
Expand All @@ -31,14 +33,13 @@ public function beforeLoad(PageCache $subject, string $identifier)
$this->cacheService->addCache('load', $identifier);
}


/**
* @param PageCache $subject
* @param string $data
* @param string $identifier
* @param array $tags
* @param $lifeTime
* @return mixed
* @return void
*/
public function beforeSave(
PageCache $subject,
Expand Down

0 comments on commit c46e17a

Please sign in to comment.