-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide query strings from the site editor top bar #368
base: master
Are you sure you want to change the base?
Conversation
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to hide only the querystrings that are being added specifically for the site editor (namely, bindingAddress
and __siteEditor
), because other query strings might be useful
d528258
to
2b84f44
Compare
Validate this PR instead ->> #374
What problem is this solving?
The query strings of the site editor URL input get in the way of the iframe pathname, which is not good for the user experience. Hiding it from the top bar but keeping that in the
window.location.search
works better!How should this be manually tested?
Workspace
Two main points to be tested with this change:
Screenshots or example usage
Before:
After:
Type of changes
Notes
X