Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide query strings from the site editor top bar #368

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

vitorflg
Copy link
Contributor

@vitorflg vitorflg commented Jan 29, 2021

Validate this PR instead ->> #374

What problem is this solving?

The query strings of the site editor URL input get in the way of the iframe pathname, which is not good for the user experience. Hiding it from the top bar but keeping that in the window.location.search works better!

How should this be manually tested?

Workspace

Two main points to be tested with this change:

  • Binding keeps working.
  • Block selector keeps working.

Screenshots or example usage

Before:
Screen Shot 2021-01-29 at 6 05 09 PM

After:
Screen Shot 2021-01-29 at 6 05 27 PM

Type of changes

✔️ Type of Change
_ Bug fix
_ New feature
_ Breaking change
✔️ Technical improvements

Notes

X

@vitorflg vitorflg requested a review from lbebber January 29, 2021 21:10
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Jan 29, 2021

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Jan 29, 2021

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link
Contributor

@lbebber lbebber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to hide only the querystrings that are being added specifically for the site editor (namely, bindingAddress and __siteEditor), because other query strings might be useful

@vitorflg vitorflg requested a review from lbebber February 11, 2021 23:20
@vitorflg vitorflg mentioned this pull request Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants