Added support for this referencing inside firebase funcs #407
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
When using typescript, it is not possible to access properties defined in
this
context. It warns that the defined props are not available in the scope with the messageError: "Property 'nameOfProp' doesn't exist on type Vue"
.Proposed solution
I augmented
VueConstructor
type so it passes default typings around onextend
function (which doesn't happen in Vue itself) and passed a CombinedInstance type asthis
for thefirestore
andfirebase
functions.I'm not sure if that's a good approach, cause it messes up with Vue module definition.
If you know a better way of implementing this, pls share.
Still not fixed
any
fix #399