Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section on enveloped verifiable presentations. #1453

Merged
merged 4 commits into from
Mar 9, 2024
Merged

Conversation

msporny
Copy link
Member

@msporny msporny commented Mar 3, 2024

This PR is an attempt to address issue #1431 by adding a way of expressing an enveloped verifiable presentation.

/cc @ChristopherA


Preview | Diff

@msporny msporny added normative The PR is a normative change to the CR specification CR1 This item was processed during CR1 labels Mar 3, 2024
@msporny msporny requested a review from iherman as a code owner March 3, 2024 22:59
@iherman
Copy link
Member

iherman commented Mar 4, 2024

@msporny this requires a change on the vocabulary as well, including a change in the vocabulary diagram. Do you prefer I do a modifiation on this branch directly (ie, adding the necessary changes) or should I do a separate PR on top of this branch? The former might be more efficient...

@msporny
Copy link
Member Author

msporny commented Mar 4, 2024

@iherman wrote:

Do you prefer I do a modifiation on this branch directly (ie, adding the necessary changes)

Yes, please. Thank you!

@iherman
Copy link
Member

iherman commented Mar 4, 2024

@iherman wrote:

Do you prefer I do a modifiation on this branch directly (ie, adding the necessary changes)

Yes, please. Thank you!

Done in 43ed6e7

@OR13
Copy link
Contributor

OR13 commented Mar 4, 2024

Non blocking comment here:

The @context configuration controls how edges form between credentials and the presentation.

In the case that JSON-LD extensibility mechanisms of the presentation object are used, implementers may want to do custom RDF processing to maintain associations between a single outer presentation and inner credentials.

In those cases, the RDF context defined in the spec does not actually control how the information graph grows.

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@iherman
Copy link
Member

iherman commented Mar 6, 2024

The issue was discussed in a meeting on 2024-03-06

  • no resolutions were taken
View the transcript

2.14. EnvelopedVerifiablePresentation missing in data model (issue vc-data-model#1431)

See github issue vc-data-model#1431.

See github pull request vc-data-model#1453.

Brent Zundel: 1431, PR1453 which has approvals and on track to be merged.
… we're headed toward wrapping this up.
… so expect to be bothered by us to get the work done...probably weekly.

index.html Outdated

<p>
It is possible to express a [=verifiable presentation=] that has been secured
using a securing mechanism that "envelopes" the payload, such as
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Distinctly, envelop is probably what we want, rather than envelope. Assuming general concurrence, the last e gets removed from envelope and envelopes, but remains in enveloped; no change is needed for enveloping. Note that there is a pronunciation change (accent on ve rather than en).

Suggested change
using a securing mechanism that "envelopes" the payload, such as
using a securing mechanism that "envelops" the payload, such as

index.html Outdated Show resolved Hide resolved
msporny and others added 2 commits March 9, 2024 11:26
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: David I. Lehn <dlehn@digitalbazaar.com>
@msporny
Copy link
Member Author

msporny commented Mar 9, 2024

@OR13 wrote:

In the case that JSON-LD extensibility mechanisms of the presentation object are used, implementers may want to do custom RDF processing to maintain associations between a single outer presentation and inner credentials.

I added some wording to highlight your concern in 2cf9040.

In those cases, the RDF context defined in the spec does not actually control how the information graph grows.

Debatable; an implementation might want it the @context to apply, or it might decide to not propagate it into the referenced object.

Given that this feature is largely meant to just encapsulate a VP encoded in just about any media type, and most of those media types won't really care about the RDF-ness of the outer-most object, it's probably fine to just stay silent on this point until the next round of the VC spec. We'd want to gather implementation experience of what people do with this before we provide more specific guidance (if that becomes necessary).

@msporny
Copy link
Member Author

msporny commented Mar 9, 2024

Normative, multiple reviews, changes requested and made, no objections, merging.

@msporny msporny merged commit d41c9af into main Mar 9, 2024
2 checks passed
@msporny msporny deleted the msporny-add-evp branch March 9, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR1 This item was processed during CR1 normative The PR is a normative change to the CR specification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants