callstack wip #108
Merged
callstack wip #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@saimeunt nice progress ser! One thing that comes to mind: can we format this as a table? So that |
|
@mazurroman A table is indeed more appropriate.
|
|
looking really good @saimeunt one small suggestion: can you wrap the table into a border too? I also suggest to change all the borders to
|
mazurroman
requested changes
Mar 20, 2024
|
@mazurroman thanks for the design help, I'm definitely not an expert on this field! 😅 |
|
looking great @saimeunt ! |
mazurroman
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP fixing #90
@mazurroman this is a simple implementation where we show the callstack in the debug tab.
The FP button is clickable to jump to the frame pointer.
Have you something more complex in mind?