TS Config cleanup 3 #2410
Open
TS Config cleanup 3 #2410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sodic
commented
Dec 10, 2024
waspc/src/Wasp/Project/WaspFile.hs
Outdated
Comment on lines
120
to
136
| -- We're using tsc to compile the *.wasp.ts file into a JS file. | ||
| -- | ||
| -- The compilation rules mostly come from tsconfig.wasp.json but also | ||
| -- include several overrides: | ||
| -- - We don't keep all the rules in tsconfig.wasp.json because it | ||
| -- would give users a way to break things. | ||
| -- - We don't keep all the rules here (inline) because users would | ||
| -- suffer bad DX (no IDE support in *.wasp.ts file). | ||
| [ "tsc", | ||
| "-p", | ||
| fromAbsFile (waspProjectDir </> tsconfigNodeFileInWaspProjectDir), | ||
| -- The tsconfig.wasp.json file has the noEmit flag on. | ||
| -- The file only exists IDE support, and we don't want users to | ||
| -- accidentally chage the outDir. | ||
| -- | ||
| -- Here, to actually generate the JS file in the desired location, | ||
| -- we must turn off the noEmit flag and specify the outDir. |
There was a problem hiding this comment.
Original discussion: #2276 (comment)
Comment on lines
-55
to
-56
| getModelNames :: Schema -> [String] | ||
| getModelNames schema = map Model.getName $ getModels schema |
There was a problem hiding this comment.
Discussed here: #2276 (comment)
Martinsos
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing stuff from #2276 and personal notes.