fix: ensure default index.html is served for app, only serve wabac.js…

… index page when in embed mode, fixes #251 bump to 1.8.13
webrecorder · Oct 6, 2023 · 906464e · 906464e
1 parent 81e81dc
commit 906464e
Show file tree

Hide file tree

Showing 5 changed files with 284 additions and 279 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,5 +1,8 @@
 ## CHANGES
 
+v1.8.13
+- Loading: Ensure default index.html is served when not in embed mode, don't add '?serveIndex=1' for app itself
+
 v1.8.12
 - Loading: Fixes embed 'Purge Cache + Reload', ensure '?serveIndex=1' is always set on all service worker loading
 

diff --git a/_data/package.json b/_data/package.json
@@ -1,7 +1,7 @@
 {
   "name": "replaywebpage",
   "productName": "ReplayWeb.page",
-  "version": "1.8.12",
+  "version": "1.8.13",
   "description": "Serverless Web Archive Replay",
   "repository": "https://github.com/webrecorder/replayweb.page",
   "homepage": "https://replayweb.page/",

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "replaywebpage",
   "productName": "ReplayWeb.page",
-  "version": "1.8.12",
+  "version": "1.8.13",
   "description": "Serverless Web Archive Replay",
   "repository": "https://github.com/webrecorder/replayweb.page",
   "homepage": "https://replayweb.page/",

diff --git a/src/appmain.js b/src/appmain.js
@@ -426,7 +426,9 @@ class ReplayWebApp extends LitElement {
     if (this.useRuffle) {
       qp.set("injectScripts", "ruffle/ruffle.js");
     }
-    qp.set("serveIndex", "1");
+    if (this.embed) {
+      qp.set("serveIndex", "1");
+    }
     query = qp.toString();
     if (query.length) {
       name += "?" + query;

diff --git a/ui.js b/ui.js