Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support description markdown and longer length #385

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Dec 23, 2024

Fixes #381

Changes

  • Renders description as markdown
  • Shows "Collection name" and "About this collection" labels when description is present
  • Fixes overflow issue where bottom few pixels of embed is cut off
  • Hides description in mobile view

Screenshots

Screenshot 2024-12-23 at 12 31 02 PM

Follow-ups

This is intended as quick fix for various description rendering issues. The sidebar display doesn't change much if description is not specified--we should do a styling pass in the future.

@SuaYoo SuaYoo requested review from emma-sg and ikreymer December 23, 2024 20:37
@emma-sg emma-sg force-pushed the issue-381-description-markdown branch from 2d76820 to fb64084 Compare December 23, 2024 20:52
@emma-sg emma-sg force-pushed the issue-381-description-markdown branch from fb64084 to 52b3cf6 Compare December 23, 2024 21:14
Copy link
Member

@emma-sg emma-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Render markdown in description panel
2 participants