Fix styling for order column when few items are in cart #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinnJS
commented
Dec 13, 2020
| @@ -8,6 +8,7 @@ const MenuItemStyles = styled.div` | |||
| align-content: center; | |||
| align-items: center; | |||
| position: relative; | |||
| max-height: 100px; | |||
There was a problem hiding this comment.
This fixes the image problem with few items, with a max-height does not allow image to stretch
LinnJS
commented
Dec 13, 2020
| @@ -21,6 +21,7 @@ const OrderStyles = styled.form` | |||
| &.order, | |||
| &.menu { | |||
| grid-column: span 1; | |||
| align-content: flex-start; | |||
There was a problem hiding this comment.
This one makes all items start at top rather than middle
|
Issue for this PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening the starter files for Master Gatsby and navigating to the Order Ahead link at the /order URL if you add one item to the cart you might noticed a stretched image in the middle of the column.
You can fix this by adding a
max-height: 100px(can make larger if you want items to be bigger at first) in theMenuItemStyles.To fix the items being in the middle of the column you can add
align-content: flex-startto the&.order, &.menuclass inOrderStyles.js.Before:
After:
