Hide language redirects in the ULS panel #490
Conversation
Around 30 languages with redirects and variants appear twice in the ULS panel. This fix checks if a redirect exists for a language code, and if it does it updates the target in the languages object and removes the redirect. Bug: T195342
|
@santhoshtr @Abijeet Could we get one of you to help review this patch? |
src/jquery.uls.core.js
Outdated
| @@ -61,6 +61,15 @@ | |||
| // Language is unknown to ULS. | |||
| delete this.languages[ code ]; | |||
| } | |||
|
|
|||
| // Check if the language code is a redirect | |||
| var target = $.uls.data.isRedirect( code ); | |||
There was a problem hiding this comment.
this.options.languages is initialized to $.uls.data.getAutonyms() by default which does not have redirects listed](
jquery.uls/src/jquery.uls.data.utils.js
Lines 93 to 105 in 8b10421
I assume somewhere some custom language options are being passed that necessitates this check. Do we know where this is being done?
src/jquery.uls.core.js
Outdated
|
|
||
| if ( target ) { | ||
| // Update target in the languages object and delete redirect | ||
| this.languages[ target ] = this.languages[ code ]; |
There was a problem hiding this comment.
What happens when the languages list has the original language (ady) and a related redirect (ady-cyrl)? Should we avoid this assignment in such cases?
Around 30 languages with redirects and variants appear twice in the ULS panel. This fix checks if a redirect exists for a language code, and if it does it updates the target in the languages object and removes the redirect. Bug: T195342
|
@Abijeet, thanks for your review of this PR! @amire80 and I discussed your comments, and I’ve made further improvements to the patch. It required an additional change in the extension, which I’ve uploaded here: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UniversalLanguageSelector/+/1087961. This PR is no longer relevant. |
Around 30 languages with redirects and variants appear twice in the ULS panel. This fix checks if a redirect exists for a language code, and if it does, it updates the target in the languages object and removes the redirect.
Bug: T195342